mysqli #340
Closed
mysqli #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to CRM-17789 I am willing to review this PR. |
|
@xurizaemon can you do so early this week so we can get it merged? |
|
Seems reviewable. Relates also to CRM-17789 & @civicrm/civicrm-core#8213 etc. |
|
Heh Jamil, as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR? |
|
Hey @JoeMurray I would certainly be up for that |
|
@mollux and @jlillyreed could you two collaborate on this PR and #384 ? Thx! |
|
@eileenmcnaughton @totten can one of you close this as there was a similar but alternate route that went down to ensure backward compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mysql_connect is deprecated, mysqli should be used instead